chore(nns): add support in release scripts for node-rewards canister#4252
chore(nns): add support in release scripts for node-rewards canister#4252max-dfinity merged 33 commits intomasterfrom
Conversation
max-dfinity
force-pushed
the
msum/nrc-canister
branch
from
ad86e75 to
56566ae
Compare
max-dfinity
force-pushed
the
msum/nrc-canister-A
branch
from
490b104 to
5bba0c2
Compare
max-dfinity
force-pushed
the
msum/nrc-canister-A
branch
2 times, most recently
from
9b84947 to
6570af0
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
There was a problem hiding this comment.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
max-dfinity
dismissed
github-actions[bot]’s stale review
No canister behavior changes
max-dfinity
force-pushed
the
msum/nrc-canister-A
branch
3 times, most recently
from
e5b17ab to
3b5b2f2
Compare
max-dfinity
force-pushed
the
msum/nrc-canister-A
branch
from
9448f28 to
43ad36e
Compare
…h existing tests)
max-dfinity
force-pushed
the
msum/nrc-canister-A
branch
from
e8bb927 to
b5c266b
Compare
max-dfinity
force-pushed
the
msum/nrc-canister-A
branch
from
0357053 to
df90c6f
Compare
max-dfinity
force-pushed
the
msum/nrc-canister-A
branch
from
df90c6f to
62d87b4
Compare
…ng from governance)
| &GENESIS_TOKEN_CANISTER_ID, | ||
| &IDENTITY_CANISTER_ID, | ||
| &NNS_UI_CANISTER_ID, | ||
| &ICP_LEDGER_ARCHIVE_CANISTER_ID, |
There was a problem hiding this comment.
it's a bit confusing to me to have zero based indexing but then not call this ICP_LEDGER_ARCHIVE_0_CANISTER_ID. isn't that inconsistent?
6 participants
No description provided.