Conversation
- **Rust Version**: Update Rust toolchain and Bazel configuration to Rust 1.85.0. - **Refactoring**: - Remove redundant `map` and `map_err` methods where conversion is unnecessary. - Simplify bitwise operations with clearer grouping. - **Tests and Comments**: Updated relevant tests and comments.
sasa-tomic
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
There was a problem hiding this comment.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
sasa-tomic
dismissed
github-actions[bot]’s stale review
No canister behavior changes.
…ba89009272f40803a49640211565e7 Image tag: 840f94ead19b1ae2da20554e111b7ca9ab0fe37e76c42b0dd06e69f370df73a0
|
Run URL: https://github.com/dfinity/ic/actions/runs/13813642063 New container image: |
|
I looked into upgrading rust a couple of days ago and I concluded (I might be wrong, though!) that we need to upgrade See also this discussion on Slack |
…c00cda858ad6612cda28b231b80896 Image tag: 3426fa29677ab9de5778c28c093194f9a45946bfaa7b910d0fc0bfa893e2a13a
|
Run URL: https://github.com/dfinity/ic/actions/runs/14311735972 New container image: |
|
We are once more waiting for the hermetic CC to be enabled. Hopefully happens soon. |
|
Any update on when this might go through? |
@stiegerc I asked IDX if there has been any progress on solving the blocker, let's see. |
…to update-rust-and-refactor-code
… the rust version bump
|
And we finally have a green PR! |
|
🥳 |
12 participants
Major Changes
1.84.0to1.85.1.Additional Changes
Refactored test assertions and other minor code improvements throughout the code base.