fix: [EXC-2006] Improve constants in wasm chunk store#4712
Merged
michael-weigelt merged 52 commits intomasterfrom Apr 11, 2025
Merged
fix: [EXC-2006] Improve constants in wasm chunk store#4712michael-weigelt merged 52 commits intomasterfrom
michael-weigelt merged 52 commits intomasterfrom
Conversation
maksymar
reviewed
Apr 10, 2025
rs/execution_environment/src/execution_environment/tests/canister_snapshots.rs
Show resolved
Hide resolved
rs/execution_environment/src/execution_environment/tests/canister_snapshots.rs
Show resolved
Hide resolved
michael-weigelt
added
the
CI_ALL_BAZEL_TARGETS
maksymar
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the wasm chunk size constant, and derive other constants from the OS page size.
Also completes a test about the maximum size of the wasm chunk store.