chore: unifying downloading logic#4805
Merged
NikolaMilosa merged 4 commits intomasterfrom Apr 15, 2025
Merged
Conversation
Bownairo
approved these changes
Apr 14, 2025
Contributor
Bownairo
left a comment
Bownairo
left a comment
There was a problem hiding this comment.
Thank you! One step closer to an async agent for us, too 👏.
Contributor
|
The nested upgrade tests that run on hourly will hit this code. Running it as a sanity check: https://github.com/dfinity/ic/actions/runs/14452611520 |
Contributor
|
https://github.com/dfinity/ic/actions/runs/14452611520 |
andrewbattat
approved these changes
Apr 14, 2025
basvandijk
added a commit
that referenced
this pull request
Apr 16, 2025
This reverts commit 943d3bf.
basvandijk
added a commit
that referenced
this pull request
Apr 16, 2025
This reverts commit 943d3bf because it breaks the `//rs/tests/nested:hostos_upgrade_smoke_test`. Schedule Hourly: https://github.com/dfinity/ic/actions/runs/14490678316 ✅ .
andrewbattat
added a commit
that referenced
this pull request
Apr 16, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 17, 2025
Builds atop and fixes #4805
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This chore builds on top of #4415.
Previously we had two ways of downloading ic os images. This PR enforces the use of
FileDownloaderutility that has support for resuming downloads.