fix(nns): Use StableBTreeMap::init instead of ::new for voting power snapshots#4877
Merged
jasonz-dfinity merged 2 commits intomasterfrom Apr 24, 2025
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
jasonz-dfinity
force-pushed
the
jason/govenrance-use-stable-btreemap-init
branch
from
c3479d3 to
5aca34b
Compare
jasonz-dfinity
force-pushed
the
jason/govenrance-use-stable-btreemap-init
branch
from
5aca34b to
50276bc
Compare
jasonz-dfinity
changed the base branch from
master
to
changelog-update-2025-04-22
daniel-wong-dfinity-org
approved these changes
Apr 24, 2025
Contributor
|
Yes, this is a pretty confusing part of ic-stable-structures. Sigh. |
jasonz-dfinity
force-pushed
the
jason/govenrance-use-stable-btreemap-init
branch
from
50276bc to
b056c3d
Compare
jasonz-dfinity
changed the base branch from
changelog-update-2025-04-22
to
master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
StableBTreeMap::newinitializes the BTreeMap as an empty map, we'd like the map to be preserved over upgrades.What
StableBTreeMap::newwithStableBTreeMap::init