fix: canister migration systest timeout and settings #7894
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basvandijk
approved these changes
Dec 2, 2025
Contributor
Author
|
We can't remove |
auto-merge was automatically disabled
December 2, 2025 12:04
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the duration of waiting for a completed migration in canister migration system test to 7 minutes (since the migration canister now waits for at least 6 minutes before completing canister migration to prevent replay attacks - see #7787).
To prevent such regressions in the future, this PR adds the system test to
PULL_REQUEST_BAZEL_TARGETSand updates its settings:long_testso that it can run on PRs usingPULL_REQUEST_BAZEL_TARGETS;enable_mainnet_nns_variant = Falsenow that the canister is actually deployed on mainnet.