feat(registry): CRP-2618 require omitting pre_signature_to_create_in_advance for vetKD in ic-admin #7989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r vetKD in ic-admin
fspreiss
added
the
CI_ALL_BAZEL_TARGETS
fspreiss
removed
the
CI_ALL_BAZEL_TARGETS
Contributor
Author
|
Turns out changing ic-admin alone cannot be done without changing the registry's subnet features struct. Closing in favor of #7981. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapts ic-admin so that the
pre_signatures_to_create_in_advancefield in chain key configurations can and must be omitted for chain keys that do not have pre-signatures. Currently this applies (only) to vetKD keys.This change is possible now that the registry was recently adapted (see Proposal 139679) to allow omitting pre_signatures_to_create_in_advance for keys that don't require it (#7859).