feat(nns): Self describing action for CreateServiceNervousSystem #8221
Conversation
jasonz-dfinity
force-pushed
the
jason/NNS1-4282-3
branch
from
3e3c21c to
6e08b0b
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):
-
Update
unreleased_changelog.md(if there are behavior changes, even if they are
non-breaking). -
Are there BREAKING changes?
-
Is a data migration needed?
-
Security review?
How to Satisfy This Automatic Review
-
Go to the bottom of the pull request page.
-
Look for where it says this bot is requesting changes.
-
Click the three dots to the right.
-
Select "Dismiss review".
-
In the text entry box, respond to each of the numbered items in the previous
section, declare one of the following:
-
Done.
-
$REASON_WHY_NO_NEED. E.g. for
unreleased_changelog.md, "No
canister behavior changes.", or for item 2, "Existing APIs
behave as before.".
Brief Guide to "Externally Visible" Changes
"Externally visible behavior change" is very often due to some NEW canister API.
Changes to EXISTING APIs are more likely to be "breaking".
If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.
If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.
Reference(s)
For a more comprehensive checklist, see here.
GOVERNANCE_CHECKLIST_REMINDER_DEDUP
jasonz-dfinity
force-pushed
the
jason/NNS1-4282-3
branch
from
6e08b0b to
4eda290
Compare
jasonz-dfinity
left a comment
jasonz-dfinity
left a comment
There was a problem hiding this comment.
Sending out responses
jasonz-dfinity
dismissed
github-actions[bot]’s stale review
No canister behavior changes (behind feature flag)
Addressing a [comment](#8221 (comment)) from a previous PR in a broader context: use SelfDescribingValue::from in tests.
2 participants
Implement the conversion to SelfDescribingAction for InstallCode/UpdateCanisterSettings/StopOrStartCanister