Skip to content

chore: CON-1316 Return ProxyDecodeError when converting NiDkg proto types #8239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eichhorl merged 1 commit into from
Jan 7, 2026
Merged

chore: CON-1316 Return ProxyDecodeError when converting NiDkg proto types #8239

eichhorl merged 1 commit into from
Jan 7, 2026

Conversation

@eichhorl
Copy link
Contributor

@eichhorl eichhorl commented Jan 6, 2026 •
edited
Loading

The convention in the repository is to return ProxyDecodeError when converting from protobuf. This PR switches the implementations of the last two remaining types still returning String to instead return ProxyDecodeError as well.

@github-actions github-actions bot added the chore label Jan 6, 2026
@eichhorl eichhorl changed the title chore: use proxy decode error chore: CON-1316 Return ProxyDecodeError when converting NiDkg proto types Jan 7, 2026
@eichhorl eichhorl marked this pull request as ready for review January 7, 2026 09:08
@eichhorl eichhorl requested a review from a team as a code owner January 7, 2026 09:08
fspreiss
fspreiss approved these changes Jan 7, 2026
View reviewed changes
Copy link
Contributor

@fspreiss fspreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eichhorl, thanks for the cleanup!

@eichhorl eichhorl added this pull request to the merge queue Jan 7, 2026
Merged via the queue into master with commit 186448b Jan 7, 2026
43 checks passed
@eichhorl eichhorl deleted the eichhorl/use-proxy-decode-error branch January 7, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fspreiss fspreiss fspreiss approved these changes

Assignees

No one assigned

Labels

chore @consensus

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eichhorl @fspreiss