chore(crypto): CRP-2409 Cleanup basic_sig ECDSA crates #8245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ECDSA basic_sig crates exported various functionality that was nominally only used for testing. Move it out of the main crates so they cannot be used in production. Update some of the top-level crypto tests to use the crypto utility packages directly instead of via the wrappers in basic_sig.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ECDSA basic_sig crates exported various functionality that was nominally only used for testing. Move it out of the main crates so they cannot be used in production.
Update some of the top-level crypto tests to use the crypto utility packages directly instead of via the wrappers in basic_sig.