fix(governance): correct canister upgrade order in golden-state test to prevent node rewards distribution failure

[pietrodimarco-dfinity]

Motivation

The Node Rewards canister updates node metrics immediately upon startup.
However, at that time the Registry canister may not yet be running, since it is often upgraded after the Node Rewards canister.
This creates a failure scenario where metric updates cannot proceed:

2026-03-15 08:09:07.483294864 UTC: [Canister sgymv-uiaaa-aaaaa-aaaia-cai] Failed to sync local registry: "Request to get_changes_since failed with code 5 and message: IC0508: Canister rwlgt-iiaaa-aaaaa-aaaaa-cai is not running"

As a result, node metrics are not updated, which blocks reward distribution.

Fix

Update the Node Rewards canister after upgrading the Registry canister to ensure the Registry remains available when metrics are refreshed.

[github-actions]

This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):

1. Update unreleased_changelog.md (if there are behavior changes, even if they are
   non-breaking).

2. Are there BREAKING changes?

3. Is a data migration needed?

4. Security review?

How to Satisfy This Automatic Review

1. Go to the bottom of the pull request page.

2. Look for where it says this bot is requesting changes.

3. Click the three dots to the right.

4. Select "Dismiss review".

5. In the text entry box, respond to each of the numbered items in the previous
   section, declare one of the following:

• Done.

• $REASON_WHY_NO_NEED. E.g. for unreleased_changelog.md, "No
  canister behavior changes.", or for item 2, "Existing APIs
  behave as before.".

Brief Guide to "Externally Visible" Changes

"Externally visible behavior change" is very often due to some NEW canister API.

Changes to EXISTING APIs are more likely to be "breaking".

If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.

If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.

Reference(s)

For a more comprehensive checklist, see here.

GOVERNANCE_CHECKLIST_REMINDER_DEDUP

[jasonz-dfinity]

LGTM, but in the PR description, I think you meant upgrading node rewards AFTER registry

Done

[daniel-wong-dfinity-org]

The title is too generic.

[daniel-wong-dfinity-org]

The title is too generic.

It should say what was broken about it, and/or how that brokenness is addressed. E.g.

Change the order of upgrades in golden state upgrade test.

(This explains how the brokenness was addressed, but not what was broken.)

[daniel-wong-dfinity-org]

Shouldn't there be some retry (so that a transient issue like Registry being upgraded) does not become a permanent issue?

[pietrodimarco-dfinity]

The title is too generic.

It should say what was broken about it, and/or how that brokenness is addressed. E.g.

Change the order of upgrades in golden state upgrade test.

(This explains how the brokenness was addressed, but not what was broken.)

Noice make sense will change it :)

[pietrodimarco-dfinity]

Shouldn't there be some retry (so that a transient issue like Registry being upgraded) does not become a permanent issue?

I believe this should be a permanent fix as the registry will be for sure running when node-rewards canister update its metrics. But happy to add retries if necessary