feat(NODE-1881): Discover external IPv6 in the cloud environment#9243
Open
blind-oracle wants to merge 9 commits intomasterfrom
Open
feat(NODE-1881): Discover external IPv6 in the cloud environment#9243blind-oracle wants to merge 9 commits intomasterfrom
blind-oracle wants to merge 9 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main points:
obtain_public_ip()method to theCloudTypethat discovers external IP. Azure only for now since AWS/GCP give direct IPv6 to the VM::) inic.json5in listening endpoints, removeipv6_addressfrom the template. Theipv6_prefixneeds to stay for now since that allows access from the /64 subnet that guest shares with host (to allow upgrades etc) - maybe we can do it somehow nicer later.ic.json5. Fallback to cloud discovery if the IP is link-local (I wonder if we might have a legitimate non-cloud use case with link-locals?)Chore:
config/tool/guestosto be able to use it from both config tool and Orchestratoripnetcrate to deal with IPv6 subnets in a clean way (instead of splitting strings etc)get_if_addrscrate in favor ofgetifs- the former only returns 1 IP address from an interface#[allow(dead_code)]clause)