refactor: Optimized clamp_debug_len.#9793
refactor: Optimized clamp_debug_len.#9793daniel-wong-dfinity-org wants to merge 3 commits intomasterfrom
Conversation
There was a problem hiding this comment.
This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):
-
Update
unreleased_changelog.md(if there are behavior changes, even if they are
non-breaking). -
Are there BREAKING changes?
-
Is a data migration needed?
-
Security review?
How to Satisfy This Automatic Review
-
Go to the bottom of the pull request page.
-
Look for where it says this bot is requesting changes.
-
Click the three dots to the right.
-
Select "Dismiss review".
-
In the text entry box, respond to each of the numbered items in the previous
section, declare one of the following:
-
Done.
-
$REASON_WHY_NO_NEED. E.g. for
unreleased_changelog.md, "No
canister behavior changes.", or for item 2, "Existing APIs
behave as before.".
Brief Guide to "Externally Visible" Changes
"Externally visible behavior change" is very often due to some NEW canister API.
Changes to EXISTING APIs are more likely to be "breaking".
If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.
If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.
Reference(s)
For a more comprehensive checklist, see here.
GOVERNANCE_CHECKLIST_REMINDER_DEDUP
| if s.len() >= 3 { | ||
| s.truncate(s.len() - 3); | ||
| s.push_str("..."); | ||
| } else { | ||
| s.push_str("..."); | ||
| } |
There was a problem hiding this comment.
The .truncate() works on bytes and it panics if the new_len lies on the char boundary. I don't think it's likely, but we shouldn't panic for debugging.
BTW, for the following suggestion, the simplification to move .push_str("..."); out is just nitpicking. I'm fine with either way.
| if s.len() >= 3 { | |
| s.truncate(s.len() - 3); | |
| s.push_str("..."); | |
| } else { | |
| s.push_str("..."); | |
| } | |
| if s.len() >= 3 { | |
| for _ in 0..3 { | |
| s.pop(); | |
| } | |
| } | |
| s.push_str("..."); |
The problem before is that if the object was huge (e.g. contained a WASM), it would generate the entire String and then, throw away most of it.
One downside of this is that this no longer shows the tail of the object. This is an unfortunate trade off, but it seems to be a net win.