Closed
Conversation
raymondk
approved these changes
Oct 31, 2025
Contributor
raymondk
left a comment
raymondk
left a comment
There was a problem hiding this comment.
This is fine for now because it is called directly by deploy.
But eventually it should be changed to handle install for a single canister in global and project mode.
That's where splitting the command from the operation makes sense because then "deploy" can call the install operation for each canister.
Contributor
|
I think this can be closed after #184 as well. Right @viviveevee ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://dfinity.atlassian.net/browse/SDK-2364