Skip to content

chore: consequently use Selections#186

Merged
viviveevee merged 6 commits intomainfrom
vivee/improve-context
Nov 4, 2025
Merged

chore: consequently use Selections#186
viviveevee merged 6 commits intomainfrom
vivee/improve-context

Conversation

@viviveevee
Copy link
Contributor

@viviveevee viviveevee commented Nov 4, 2025 •
edited
Loading

  • introduce NetworkOpt
  • Canister*Args now takes SomethingOpt instead of rolling its own arguments
  • update Context functions to take SomethingSelection everywhere, no more network_name: &str and similar
  • use constants for default network/environment names

@viviveevee viviveevee marked this pull request as ready for review November 4, 2025 13:28
@viviveevee viviveevee requested a review from a team as a code owner November 4, 2025 13:28
@viviveevee viviveevee merged commit 3d43277 into main Nov 4, 2025
44 checks passed
@viviveevee viviveevee deleted the vivee/improve-context branch November 4, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamspofford-dfinity adamspofford-dfinity adamspofford-dfinity approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@viviveevee @adamspofford-dfinity