Skip to content

feat: wipe out canister ID mappings when network start#202

Merged
lwshang merged 3 commits intomainfrom
lwshang/SDK-2417_wipe_cache_when_network_start
Nov 18, 2025
Merged

feat: wipe out canister ID mappings when network start#202
lwshang merged 3 commits intomainfrom
lwshang/SDK-2417_wipe_cache_when_network_start

Conversation

@lwshang
Copy link
Contributor

@lwshang lwshang commented Nov 18, 2025

When icp network run, the canister ID mappings of environments that point to the current managed network will be deleted.

Test

This is test manually in examples/icp-pre-built.

The following workflow failed before this PR:

Terminal 1 Terminal 2
icp network run
icp deploy
CTRL-C
icp network run
icp deploy

I tried to add an integration test for it. But this not trivial because:

  • The test framework doesn't support stopping a non-background network
  • Start network twice result in panic
  • icp network run --background then icp deploy would fail with:
    • "agent error: An error happened during communication with the replica"

@lwshang lwshang marked this pull request as ready for review November 18, 2025 20:18
@lwshang lwshang requested a review from a team as a code owner November 18, 2025 20:18
@lwshang lwshang merged commit 49e115c into main Nov 18, 2025
44 checks passed
@lwshang lwshang deleted the lwshang/SDK-2417_wipe_cache_when_network_start branch November 18, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants