feat: allow token/cycles commands to target networks#207
Merged
Conversation
raymondk
reviewed
Nov 20, 2025
|
|
||
| let cid = ctx | ||
| .get_canister_id(&canister_selection, &environment_selection) | ||
| .get_canister_id_for_env(&canister_selection, &environment_selection) |
Contributor
There was a problem hiding this comment.
This is not going to work if the canister selection is a principal.
We could:
- use
ctx.get_canister_idand pass the default network. - leave it as is for now - the command doesn't do anything super special at the moment - but perhaps add a comment.
This is a weird command: unlike all the other commands which could be used inside or outside the context of project this one doesn't make much sense outside of a project.
raymondk
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR it becomes possible to do
icp cyclesandicp tokenoperations outside of a project, e.g. when targeting--mainnet