fix: use dorny/paths-filter so required checks pass on docs-only PRs#427
Merged
fix: use dorny/paths-filter so required checks pass on docs-only PRs#427
Conversation
Replace workflow-level `paths-ignore` with job-level path filtering using `dorny/paths-filter`. When a PR only touches docs, markdown, or npm files the work jobs are skipped — but the workflow still triggers, so required status checks (fmt:required, lint:required, test:required) report as skipped instead of missing entirely. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
| name: ${{ matrix.test }} on ${{ matrix.os }} | ||
| # Wait until unit tests have run so we can reuse the cache | ||
| needs: [discover, unit-tests] | ||
| if: needs.discover.result == 'success' |
Contributor
There was a problem hiding this comment.
Why's this one different?
Contributor
Author
There was a problem hiding this comment.
Added an inline comment explaining why: this job needs discover's matrix output (via fromJson), which is only available when discover actually ran — so we check its result rather than changes.outputs.src.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
adamspofford-dfinity
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
paths-ignorewith job-level path filtering usingdorny/paths-filterinchecks.yml,test.yml, andvalidate-examples.ymlfmt:required,lint:required,test:required) report as "skipped" instead of missing entirelyTest plan
🤖 Generated with Claude Code