fix: commit docs canister ID mapping and tighten gitignore#442
Merged
Conversation
- Only ignore .icp/cache (not all of .icp/) so canister ID mappings can be committed as intended for icp projects - Remove outdated .icpdata ignore entry (no longer used) - Ignore examples/*/.icp/ since this repo does not track canister IDs for the examples (neither local nor mainnet deployments) - Commit docs-site/.icp/data/mappings/ic.ids.json (canister ID for docs) - Restore cp in workflow (file is now in source control) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
raymondk
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failing
docs.ymlworkflow after #439 merged.Changes
.gitignore: Only ignore.icp/cacheinstead of all of.icp/— canister ID mappings are meant to be committed in icp projects. Remove outdated.icpdataentry (no longer used by the tool). Ignoreexamples/*/.icp/since this repo does not track canister IDs for the examples.docs-site/.icp/data/mappings/ic.ids.json: Added to source control now that.icp/is no longer fully gitignored.docs.yml: Reverts inline canister ID back tocpfrom file (now that the file is tracked).Root cause
The original
.gitignoreignored all of.icp/because this is the icp-cli development repo. Butdocs-site/.icp/data/mappings/ic.ids.jsonneeds to be committed for thepublish-root-filesworkflow job to copy it todocs-deployment.