Skip to content

fix: use always() so deploy-to-ic runs when publish-versioned-docs is skipped#444

Merged
marc0olo merged 1 commit intomainfrom
fix/docs-deploy-always-condition
Mar 18, 2026
Merged

fix: use always() so deploy-to-ic runs when publish-versioned-docs is skipped#444
marc0olo merged 1 commit intomainfrom
fix/docs-deploy-always-condition

Conversation

@marc0olo
Copy link
Member

Problem

After #443 merged, deploy-to-ic still wasn't triggering on pushes to main. The run 23236250900 shows deploy-to-ic as skipped.

Root cause: GitHub automatically skips dependent jobs when any needed job is skipped, regardless of the if: condition. On main branch pushes, publish-versioned-docs is correctly skipped (it only runs on v* tags and docs/v* branches). But this cascades and also skips deploy-to-ic.

Fix

Add always() to the if: condition to opt out of the cascade-skip behavior, while keeping explicit guards against failures and cancellations:

if: always() && github.event_name != 'pull_request' && !contains(needs.*.result, 'failure') && !contains(needs.*.result, 'cancelled')

This ensures:

  • ✅ Runs on main push (even though publish-versioned-docs is skipped)
  • ✅ Runs on tag/docs/v* push (all three publish jobs ran)
  • ✅ Skipped on PR builds
  • ✅ Skipped if any publish job failed or was cancelled

…cs is skipped

GitHub auto-skips dependent jobs when any needed job is skipped, regardless
of the if: condition. Using always() prevents this while the explicit
failure/cancelled checks ensure we still don't deploy on errors.

On main branch pushes publish-versioned-docs is correctly skipped (no tag),
but without always() this caused deploy-to-ic to also be skipped.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@marc0olo marc0olo requested a review from a team as a code owner March 18, 2026 08:50
@marc0olo marc0olo enabled auto-merge (squash) March 18, 2026 08:52
@marc0olo marc0olo merged commit 69a2961 into main Mar 18, 2026
156 of 158 checks passed
@marc0olo marc0olo deleted the fix/docs-deploy-always-condition branch March 18, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants