fix: Network fails to start if a stale network descriptor is present#466
Merged
fix: Network fails to start if a stale network descriptor is present#466
Conversation
Clean port descriptor before project descriptor so the global resource is freed first. Pass gateway_port() directly since cleanup_port_descriptor already handles None. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lwshang
approved these changes
Mar 24, 2026
…indows The test used 1GiB/2GiB allocations which require the system to reserve a large portion of the initial 2T cycle balance, leaving the canister short on cycles with newer pocket-ic-server versions. Using 10MiB/20MiB still verifies the environment settings override mechanism while keeping memory reservation costs negligible. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there's a leftover network descriptor icp-cli would bail too early without checking if the network was indeed started.