Skip to content

chore(candid): update nns package#1449

Merged
yhabib merged 2 commits intomainfrom
yhabib/new-nns-did
Jan 16, 2026
Merged

chore(candid): update nns package#1449
yhabib merged 2 commits intomainfrom
yhabib/new-nns-did

Conversation

@yhabib
Copy link
Contributor

@yhabib yhabib commented Jan 16, 2026 •
edited by 0xFFrancesco
Loading

Motivation

There are two new proposal types TakeCanisterSnapshot and LoadCanisterSnapshot introduced here and here. This PR manually bumps the version of the monorepo for the nns package.

Changes

  1. Checked out top of IC repo.
  2. Ran scripts/import-candid ../ic (works with siblings directories - locally).
  3. Ran scripts/compile-idl-js.
  4. Reverted files outside packages/nns (to update only the NNS).
  5. Updated Action types.

Tests

  • Added unit tests.

Todos

  • Add entry to changelog (if necessary).

@yhabib yhabib changed the title feat(core): update nns candid files chore(candid): update nns package Jan 16, 2026
@yhabib yhabib mentioned this pull request Jan 16, 2026
Merged
2 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026

size-limit report 📦

Path Size
@dfinity/ckbtc 8.68 KB (0%)
@dfinity/cketh 3.71 KB (0%)
@dfinity/cmc 1.63 KB (0%)
@dfinity/ledger-icrc 4.94 KB (0%)
@dfinity/ledger-icp 7.16 KB (0%)
@dfinity/nns 25.4 KB (+0.68% 🔺)
@dfinity/nns-proto 141 KB (0%)
@dfinity/sns 19.94 KB (+0.01% 🔺)
@dfinity/utils 5.11 KB (0%)
@dfinity/zod-schemas 627 B (0%)
@dfinity/ic-management 4.52 KB (0%)
@icp-sdk/canisters/assets 10.3 KB (0%)
@icp-sdk/canisters/ckbtc 8.68 KB (-0.02% 🔽)
@icp-sdk/canisters/cketh 3.71 KB (0%)
@icp-sdk/canisters/cmc 1.64 KB (0%)
@icp-sdk/canisters/ledger/icrc 4.94 KB (0%)
@icp-sdk/canisters/ledger/icp 7.17 KB (+0.02% 🔺)
@icp-sdk/canisters/ledger/cycles 2.17 KB (0%)
@icp-sdk/canisters/nns 25.4 KB (+0.68% 🔺)
@icp-sdk/canisters/sns 19.94 KB (+0.01% 🔺)
@icp-sdk/canisters/ic-management 4.52 KB (0%)

@yhabib yhabib marked this pull request as ready for review January 16, 2026 11:52
@yhabib yhabib requested review from a team as code owners January 16, 2026 11:52
@yhabib yhabib merged commit 2fab86b into main Jan 16, 2026
16 checks passed
@yhabib yhabib deleted the yhabib/new-nns-did branch January 16, 2026 12:32
@yhabib yhabib mentioned this pull request Jan 16, 2026
Merged
2 tasks
github-merge-queue bot pushed a commit to dfinity/nns-dapp that referenced this pull request Jan 16, 2026
@yhabib
feat(i18n): add translations for new proposal actions TakeCanisterSna…
656aec9 
…pshot and LoadCanisterSnapshot (#7681)

# Motivation

Two new action proposals, `TakeCanisterSnapshot` and
`LoadCanisterSnapshot`, have been added. This PR introduces support for
the i18n aspect of the proposal, enabling it to be rendered in the
nns-dapp.

Required changes:

* [Candid support](#7685) for
new proposal action in the nns-dapp.
* Bumps candid interface in
[ic-js](dfinity/icp-js-canisters#1449).
* Adds support to new version of ic-js in
[nns-dapp](#7686) in the
nns-dapp.


# Changes

- Add translations to for the new proposal action.

# Tests

- Not possible

# Todos

- [x] Accessibility (a11y) – any impact?
- [x] Changelog – is it needed?
github-merge-queue bot pushed a commit to dfinity/nns-dapp that referenced this pull request Jan 16, 2026
@yhabib
chore(deps): upgrade icp-js-canisters to include new proposal actions (…
2fcfbaa 
…#7686)

# Motivation

Bump the icp-js library to incorporate the changes for the new
[Proposals Action
types](dfinity/icp-js-canisters#1449).

# Changes

- Ran `npm run upgrade:next`.

# Tests

- CI should pass.

# Todos

- [x] Accessibility (a11y) – any impact?
- [x] Changelog – is it needed?
@yhabib yhabib mentioned this pull request Jan 16, 2026
Merged
1 task
yhabib added a commit that referenced this pull request Jan 18, 2026
@yhabib
fix(types): remove duplicate action enum entries and update changelog (…
f128a9e 
…#1450)

# Motivation

#1449 introduced a duplication of two types in the Action type enum.

# Changes

- Remove duplication.
- Added the missing entry to the changelog in #1449

# Tests

- CI should pass as before.

# Todos

- [x] Add entry to changelog (if necessary).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xFFrancesco 0xFFrancesco 0xFFrancesco approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yhabib @0xFFrancesco