Skip to content

feat: support for latest II and create passkey option#60

Merged
peterpeterparker merged 4 commits intomainfrom
feat/ii-passkey
May 14, 2025
Merged

feat: support for latest II and create passkey option#60
peterpeterparker merged 4 commits intomainfrom
feat/ii-passkey

Conversation

@peterpeterparker
Copy link
Member

@peterpeterparker peterpeterparker commented May 14, 2025

Motivation

In one of the latest Internet Identity releases, the flow was modified to no longer require the user to create and save a passkey as a dedicated step. As a result, this plugin is incompatible with the new flow, as reported in #56.

Breaking Changes

This PR introduces a breaking change because Internet Identity itself has introduced a breaking change—i.e., we now assume the new behavior is the standard moving forward.

Changes

  • Add an option to use a flow that explicitly requires the passkey creation step. This is useful when using older versions of Internet Identity.
  • Default to not using the passkey-required step to align with the latest II behavior.
  • Add a dedicated test and setup to validate this new option.
  • Document new option.

@peterpeterparker peterpeterparker marked this pull request as ready for review May 14, 2025 12:02
@peterpeterparker peterpeterparker requested a review from a team as a code owner May 14, 2025 12:02
Copy link
Collaborator

@AntonioVentilii AntonioVentilii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tks!!!

@peterpeterparker peterpeterparker merged commit 5269535 into main May 14, 2025
12 checks passed
@peterpeterparker peterpeterparker deleted the feat/ii-passkey branch May 14, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Playwright E2E Test for Internet Identity Fails with Timeout on [data-action=construct-identity]

2 participants