Skip to content

refactor: extract spec constants for container #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterpeterparker merged 1 commit into from
May 14, 2025
Merged

refactor: extract spec constants for container #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions e2e/captcha.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
import {testWithII} from '../src';
import {DOCKER_CONTAINER} from './spec.constants';

testWithII.beforeEach(async ({iiPage, browser}) => {
const DOCKER_CONTAINER_URL = 'http://127.0.0.1:5987';
const DOCKER_INTERNET_IDENTITY_ID = 'rdmx6-jaaaa-aaaaa-aaadq-cai';

await iiPage.waitReady({url: DOCKER_CONTAINER_URL, canisterId: DOCKER_INTERNET_IDENTITY_ID});
await iiPage.waitReady(DOCKER_CONTAINER);
});

testWithII('should sign-in with a new user when II requires a captcha', async ({page, iiPage}) => {
Expand Down
6 changes: 2 additions & 4 deletions e2e/login.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
import {testWithII} from '../src';
import {DOCKER_CONTAINER} from './spec.constants';

const loginSelector = '#login';
const logoutSelector = '#logout';

testWithII.beforeEach(async ({iiPage, browser}) => {
const DOCKER_CONTAINER_URL = 'http://127.0.0.1:5987';
const DOCKER_INTERNET_IDENTITY_ID = 'rdmx6-jaaaa-aaaaa-aaadq-cai';

await iiPage.waitReady({url: DOCKER_CONTAINER_URL, canisterId: DOCKER_INTERNET_IDENTITY_ID});
await iiPage.waitReady(DOCKER_CONTAINER);
});

testWithII.describe('without selector', () => {
Expand Down
7 changes: 7 additions & 0 deletions e2e/spec.constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
const DOCKER_CONTAINER_URL = 'http://127.0.0.1:5987';
const DOCKER_INTERNET_IDENTITY_ID = 'rdmx6-jaaaa-aaaaa-aaadq-cai';

export const DOCKER_CONTAINER = {
url: DOCKER_CONTAINER_URL,
canisterId: DOCKER_INTERNET_IDENTITY_ID
};