chore: Fix candid encoding for II upgrade args#3641
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the release SOP script used to deploy an Internet Identity (II) release candidate and generate/verify upgrade arguments, aiming to ensure the Candid upgrade args are encoded correctly for upgrades.
Changes:
- Switches upgrade-arg encoding to
didc encode -d ... -t ...to force the intended type during encoding. - Adjusts the
dfx canister installinvocation to use--argument-type rawand consume a generated argument artifact.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sea-snake
reviewed
Feb 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR ensures that the Candid encoding of II install arguments takes API type definitions into account. Candid encoding should use the correct type definitions, not automatically inferred types, otherwise distinct variant cases may get unexpectedly collapsed into one.
Changes
Provide options
-d ./src/internet_identity/internet_identity.did -t '(opt InternetIdentityInit)'to allcandidcommands in the upgrade script.Tests
Tested manually.