Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| issuer: openid_credential.iss.clone(), | ||
| }); | ||
| // It is important here to rely on the issuer ID as opposed to `openid_credential.iss` | ||
| // becasue, e.g., for Microsoft accounts, the issuer has a tenant ID parameter |
There was a problem hiding this comment.
Typo in comment: "becasue" should be "because".
Suggested change
| // becasue, e.g., for Microsoft accounts, the issuer has a tenant ID parameter | |
| // because, e.g., for Microsoft accounts, the issuer has a tenant ID parameter |
Contributor
Author
There was a problem hiding this comment.
Will fix this in a follow-up PR
sea-snake
approved these changes
Mar 6, 2026
Contributor
sea-snake
left a comment
sea-snake
left a comment
There was a problem hiding this comment.
LGTM, see Copilot nits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Microsoft's OpenID issuer ID contains a
{tid}placeholder that can have multiple instantiations.Since OpenID attributes scopes are literal OpenID issuer IDs, this whole is also expected to be part of the scope.
But the II backend interpolated
{tid}with the actual tenant ID from the user's credentials. Thus, matching requested OpenID attributed over OpenID attributes available for a given user should be done using the proper (non-interpolated) OpenID issuer ID.Changes
Tests