Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the “identity switcher” UI and related flows to match a redesigned UX, including showing more identity context (avatar + auth method), removing the previous 3-identity display cap, and updating layouts and E2E tests to the new labels/behavior.
Changes:
- Redesign
IdentitySwitcherUI/behavior and update consuming layouts (manage/authorize/index) to match the new design and auto-authorize on identity switch in the authorize flow. - Adjust shared UI components (
Avatar,Popover,Dialog,Select) to support the new styling/interaction requirements. - Update OpenID logo handling to avoid SVG ID collisions, and update Playwright E2E tests for new button labels.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/frontend/tests/e2e-playwright/utils.ts | Updates identity-switcher button label used by helpers. |
| src/frontend/tests/e2e-playwright/routes/manage/migration.spec.ts | Updates identity-switcher label in manage migration test. |
| src/frontend/tests/e2e-playwright/routes/index.spec.ts | Updates flows to match redesigned identity switcher actions/labels. |
| src/frontend/tests/e2e-playwright/routes/authorize/continue.spec.ts | Updates authorize tests to match new switcher behavior (auto-continue). |
| src/frontend/tests/e2e-playwright/fixtures/identity.ts | Updates identity wizard expected buttons list. |
| src/frontend/src/routes/(new-styling)/manage/(authenticated)/+layout.svelte | Redesigns mobile identity trigger and removes 3-identity cap in derived list. |
| src/frontend/src/routes/(new-styling)/+page.svelte | Updates top-right identity button styling (avatar + name) and removes 3-identity cap. |
| src/frontend/src/routes/(new-styling)/(channel)/authorize/+layout.svelte | Auto-authorizes when switching identity from the switcher; updates identity button UI. |
| src/frontend/src/lib/utils/openID.ts | Namespaces SVG IDs in OpenID logos to prevent DOM collisions. |
| src/frontend/src/lib/components/ui/Select.svelte | Removes ! padding override now that Popover/Dialog padding behavior changed. |
| src/frontend/src/lib/components/ui/Popover.svelte | Removes default padding and ensures Dialog-rendered popovers can be paddingless. |
| src/frontend/src/lib/components/ui/IdentitySwitcher.svelte | Full redesign: selected identity card, list UI, “Add another identity”, manage action. |
| src/frontend/src/lib/components/ui/Dialog.svelte | Adds contentClass and improves touch scrolling to support inner scrollables. |
| src/frontend/src/lib/components/ui/Avatar.svelte | Adds xs size for new header identity button design. |
| src/frontend/src/lib/app.css | Sets color-scheme: light dark to improve scrollbar theming. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/frontend/src/routes/(new-styling)/manage/(authenticated)/+layout.svelte
Show resolved
Hide resolved
src/frontend/src/routes/(new-styling)/manage/(authenticated)/+layout.svelte
Outdated
Show resolved
Hide resolved
aterga
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redesigned identity switcher
Changes
Avatarcomponent.Dialogif rendered byPopover.Popovercomponent to remove default paddingDialogtouch scroll logic to support scrolling inner scrollable elements.IdentitySwitchercomponent to match updated design.!syntax fromSelectpadding styling since it's no longer needed.namespaceIdsmethod to name space all IDS inside SVG string to fix the Google logo when rendered multiple times on the page.color-schemeto root css to make sure scrollbars are colored correctly according to the system color scheme.ButtonCardon mobile to match updated design (button used to open the identity switcher on the mobile manage pages).Tests
Various e2e tests have been updated to match the redesigned identity switcher labels and behavior.