feat: Add minimal guided upgrade flag (collapsed by default)#3653
Merged
feat: Add minimal guided upgrade flag (collapsed by default)#3653
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new MIN_GUIDED_UPGRADE feature flag to enable the guided upgrade UI in a “minimal” mode where the upgrade panel starts collapsed.
Changes:
- Introduce
MIN_GUIDED_UPGRADEfeature flag store and register it with the global feature-flag registry. - Render the guided upgrade panel when either
GUIDED_UPGRADEorMIN_GUIDED_UPGRADEis enabled. - Default the guided upgrade panel to collapsed when
MIN_GUIDED_UPGRADEis enabled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/frontend/src/routes/(new-styling)/(channel)/authorize/(panel)/+layout.svelte |
Show upgrade panel under the new flag and default it to collapsed when MIN_GUIDED_UPGRADE is enabled. |
src/frontend/src/lib/state/featureFlags.ts |
Add and export the MIN_GUIDED_UPGRADE feature flag store so it can be initialized/overridden like other flags. |
Comments suppressed due to low confidence (1)
src/frontend/src/routes/(new-styling)/(channel)/authorize/(panel)/+layout.svelte:158
- When
MIN_GUIDED_UPGRADEis enabled and aselectedIdentityexists, theAuthPanelrounding logic still checks only$GUIDED_UPGRADE, so the panel won't getrounded-t-noneeven though the upgrade panel is rendered above it. Align this condition with the else-branch (includeMIN_GUIDED_UPGRADE), ideally by using a single derived boolean (e.g.showGuidedUpgrade) to avoid these branches drifting again.
<AuthPanel
class={[
"z-1",
$GUIDED_UPGRADE && isUpgradeCollapsed && "rounded-t-none",
]}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aterga
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add minimal guided upgrade flag (collapsed by default).
To use this new feature flag, the app would need to set, e.g.:
identityProvider: "https://id.ai/authorize?feature_flag_min_guided_upgrade=true"Changes
MIN_GUIDED_UPGRADEfeature flag.