Skip to content

feat: Add minimal guided upgrade flag (collapsed by default)#3653

Merged
aterga merged 1 commit intomainfrom
sea-snake/minimal-guided-upgrade-flag
Mar 6, 2026
Merged

feat: Add minimal guided upgrade flag (collapsed by default)#3653
aterga merged 1 commit intomainfrom
sea-snake/minimal-guided-upgrade-flag

Conversation

@sea-snake
Copy link
Contributor

@sea-snake sea-snake commented Mar 6, 2026

Add minimal guided upgrade flag (collapsed by default).

To use this new feature flag, the app would need to set, e.g.:

identityProvider: "https://id.ai/authorize?feature_flag_min_guided_upgrade=true"

Changes

  • Add MIN_GUIDED_UPGRADE feature flag.
  • Show guided upgrade when flag is enabled.
  • Make sure the guided upgrade is collapsed in case this flag is enabled.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new MIN_GUIDED_UPGRADE feature flag to enable the guided upgrade UI in a “minimal” mode where the upgrade panel starts collapsed.

Changes:

  • Introduce MIN_GUIDED_UPGRADE feature flag store and register it with the global feature-flag registry.
  • Render the guided upgrade panel when either GUIDED_UPGRADE or MIN_GUIDED_UPGRADE is enabled.
  • Default the guided upgrade panel to collapsed when MIN_GUIDED_UPGRADE is enabled.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/frontend/src/routes/(new-styling)/(channel)/authorize/(panel)/+layout.svelte Show upgrade panel under the new flag and default it to collapsed when MIN_GUIDED_UPGRADE is enabled.
src/frontend/src/lib/state/featureFlags.ts Add and export the MIN_GUIDED_UPGRADE feature flag store so it can be initialized/overridden like other flags.
Comments suppressed due to low confidence (1)

src/frontend/src/routes/(new-styling)/(channel)/authorize/(panel)/+layout.svelte:158

  • When MIN_GUIDED_UPGRADE is enabled and a selectedIdentity exists, the AuthPanel rounding logic still checks only $GUIDED_UPGRADE, so the panel won't get rounded-t-none even though the upgrade panel is rendered above it. Align this condition with the else-branch (include MIN_GUIDED_UPGRADE), ideally by using a single derived boolean (e.g. showGuidedUpgrade) to avoid these branches drifting again.
        <AuthPanel
          class={[
            "z-1",
            $GUIDED_UPGRADE && isUpgradeCollapsed && "rounded-t-none",
          ]}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aterga aterga added this pull request to the merge queue Mar 6, 2026
Merged via the queue into main with commit ba05223 Mar 6, 2026
70 checks passed
@aterga aterga deleted the sea-snake/minimal-guided-upgrade-flag branch March 6, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants