chore: Update npm deps and node version by sea-snake · Pull Request #3664 · dfinity/internet-identity

sea-snake · 2026-03-10T15:35:07Z

Update npm deps and node version including .nvmrc.

Changes

Remove unused dependencies previously used with legacy frontend CI and/or showcase.
Bump all dependencies to latest versions.
Add ./scripts/rewrite-dfinity-imports.sh to fix generated did interface imports since latest @icp-sdk/core no longer export @dfinity libs.
Update node and npm version to latest lts in package.json and add .nvmrc.
Use $effect.pre in components where props were used directly to initialize state (resolves svelte lint warning).
Add keys to svelte #each blocks (resolves svelte lint warning).
Update SignIdentity implementation since agent-js has switched to Uint8Array.
Update ts config lib from ES2021 to ES2022 to support source argument in error constructor (resolve lint warning).
Update canister forwarding plugin implementation to work with latest vite.

Tests

All existing tests should pass as-is.

…pm-deps

Copilot

Pull request overview

This PR upgrades the repository’s Node/npm and npm dependencies (notably Svelte/Vite/Vitest and @icp-sdk/*), and updates the frontend codebase to accommodate the new SDK/agent types plus updated lint rules. It also adds a small codegen post-processing script to keep generated did bindings compatible with the @icp-sdk/core/* import paths.

Changes:

Bump Node/npm requirements and update dependency versions across workspaces (Vite/Vitest/Svelte/TypeScript, @icp-sdk/*, etc.).
Migrate various identity / WebAuthn / recovery phrase utilities from ArrayBuffer to Uint8Array and replace @noble/hashes hex helpers with local toHex/fromHex.
Address new Svelte/eslint warnings (keys in #each, $effect.pre for derived state initialization, updated ESLint TS project config) and add scripts/rewrite-dfinity-imports.sh to rewrite generated did imports.

Reviewed changes

Copilot reviewed 50 out of 53 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tsconfig.eslint.json	Add dedicated TS project for ESLint (includes Svelte + generated ambient types).
tsconfig.base.json	Update TS lib target to ES2022.
src/vite-plugins/src/index.ts	Update compression plugin configuration for newer `vite-plugin-compression2`.
src/vite-plugins/package.json	Bump Vite + compression plugin versions for the vite-plugins workspace.
src/vc-api/src/generated/vc_issuer_types.ts	Rewrite generated did imports from `@dfinity/` to `@icp-sdk/core/`.
src/sig-verifier-js/package.json	Upgrade TypeScript/Vite/Vitest tooling in sig-verifier workspace.
src/frontend/src/routes/(new-styling)/self-service/+page.svelte	Lint fixes (keys, `void` for ignored promises) + hex conversion via `toHex`.
src/frontend/src/routes/(new-styling)/manage/(authenticated)/(access-and-recovery)/access/utils.ts	Use local `toHex` instead of `@noble/hashes` for passkey credential IDs.
src/frontend/src/routes/(new-styling)/manage/(authenticated)/(access-and-recovery)/access/utils.test.ts	Update expectations to use `toHex`.
src/frontend/src/routes/(new-styling)/manage/(authenticated)/(access-and-recovery)/access/components/RenamePasskey.svelte	Switch to `$effect.pre` pattern for prop-driven state init; lint fixes.
src/frontend/src/routes/(new-styling)/manage/(authenticated)/(access-and-recovery)/access/+page.svelte	Prop/state initialization changes and promise-handling lint fixes (`void goto`).
src/frontend/src/lib/utils/webAuthnIdentity.ts	Adapt WebAuthn identity implementation to `Uint8Array` APIs + local hex helpers.
src/frontend/src/lib/utils/webAuthn.ts	Switch from `bufferEqual` to `uint8ArrayEqual` for key comparisons.
src/frontend/src/lib/utils/utils.ts	Add `uint8ArrayEqual`, base64 helpers with fallbacks, and `toHex/fromHex`.
src/frontend/src/lib/utils/trackWindowSession.test.ts	Adjust test callback typings.
src/frontend/src/lib/utils/recoveryPhrase.ts	Use `toHex` and normalize inputs to WebCrypto (`Uint8Array`).
src/frontend/src/lib/utils/recoveryPhrase.test.ts	Use `fromHex` for test vectors instead of `@noble/hashes`.
src/frontend/src/lib/utils/multiWebAuthnIdentity.ts	Update signing APIs to `Uint8Array` and credentialId comparisons to `uint8ArrayEqual`.
src/frontend/src/lib/utils/iiConnection.ts	Update WebAuthn identity typing (`rawId` to `Uint8Array`) and improve error cause.
src/frontend/src/lib/utils/iiConnection.test.ts	Update mocks/signatures to match `Uint8Array`-based agent APIs.
src/frontend/src/lib/utils/findWebAuthnFlows.test.ts	Update test credentialId types to `Uint8Array`.
src/frontend/src/lib/utils/discoverablePasskeyIdentity.ts	Normalize WebAuthn/CBOR inputs and migrate credential IDs to `Uint8Array`.
src/frontend/src/lib/utils/discoverableDummyIdentity.ts	Align dummy identity credentialId typing with `Uint8Array`.
src/frontend/src/lib/utils/credential-devices.ts	Change credential IDs to `Uint8Array` and adjust DER pubkey handling.
src/frontend/src/lib/utils/authentication/passkey.ts	Replace `bytesToHex` with `toHex` and simplify credential ID usage.
src/frontend/src/lib/utils/animation-dispatcher.ts	Export `TriggerFunction` type for tests/consumers.
src/frontend/src/lib/utils/animation-dispatcher.test.ts	Update typing/casts to use exported `TriggerFunction`.
src/frontend/src/lib/stores/authorization.store.ts	Ensure stored session public key is `Uint8Array`.
src/frontend/src/lib/legacy/storage/index.ts	Normalize WebCrypto HMAC inputs to `Uint8Array`.
src/frontend/src/lib/generated/internet_identity_types.d.ts	Rewrite generated did imports to `@icp-sdk/core/*`.
src/frontend/src/lib/flows/registerAccessMethodFlow.svelte.ts	Use `SvelteURL/SvelteDate` for reactive-safe URL/date values.
src/frontend/src/lib/flows/recoverWithPhraseFlow.svelte.ts	Move agent imports to `@icp-sdk/core/*` and use `uint8ArrayEqual`.
src/frontend/src/lib/flows/migrationFlow.svelte.ts	Use `SvelteDate` in delegation expiration.
src/frontend/src/lib/flows/confirmAccessMethodFlow.svelte.ts	Use `SvelteURL` for reactive-safe URL values.
src/frontend/src/lib/flows/authLastUsedFlow.svelte.ts	Use `SvelteMap` for reactive-safe map state.
src/frontend/src/lib/flows/authFlow.svelte.ts	OpenID request config updated (note: `configURL` removed).
src/frontend/src/lib/components/wizards/createRecoveryPhrase/CreateRecoveryPhraseWizard.svelte	Use `$effect.pre` to initialize local state from props without lint warnings.
src/frontend/src/lib/components/views/RecoveryPhraseInput.svelte	Prop-driven state init via `$effect.pre`, lazy import lint fix, add keyed `#each`.
src/frontend/src/lib/components/views/EditAccount.svelte	Prop-driven state init via `$effect.pre`.
src/frontend/src/lib/components/utils/ButtonOrAnchor.svelte	Derive `buttonProps/anchorProps` with `$derived` to satisfy lint rules.
src/frontend/src/lib/components/utils/AuthorizationChannel.svelte	Refactor authorize promise creation; avoid floating `goto` promise.
src/frontend/src/lib/components/ui/Tooltip.svelte	Lint ignore + minor attribute syntax normalization.
src/frontend/src/lib/components/ui/TextFade.svelte	Timer typing fix and avoid floating promise in `next()`.
src/frontend/src/lib/components/ui/ProgressRing.svelte	Make derived value reactive with `$derived`.
src/frontend/src/lib/components/ui/IdentitySwitcher.svelte	Add lint ignore for local state snapshots.
scripts/rewrite-dfinity-imports.sh	Add sed-based rewrite to convert generated `@dfinity/` imports to `@icp-sdk/core/`.
package.json	Update engines, bump dependencies, and pipe didc outputs through rewrite script.
eslint.config.js	Point ESLint to `tsconfig.eslint.json`, include Svelte TS/JS, adjust Svelte lint rule.
demos/vc_issuer/package.json	Bump Vite + React plugin + polyfills in demo workspace.
demos/test-app/package.json	Bump Vite + React plugin + polyfills in demo workspace.
.nvmrc	Pin Node version for local development.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/frontend/src/lib/flows/authFlow.svelte.ts

src/frontend/src/lib/utils/utils.ts

src/frontend/src/lib/utils/webAuthnIdentity.ts

Copilot

Pull request overview

Copilot reviewed 51 out of 54 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/frontend/src/lib/utils/utils.ts

src/frontend/src/routes/(new-styling)/self-service/+page.svelte

src/sig-verifier-js/tests.ts

src/sig-verifier-js/package.json

package.json

aterga · 2026-03-10T19:32:23Z

scripts/rewrite-dfinity-imports.sh

Why do we need this file?

Since the current didc setup generates js/ts files with @dfinity/* imports instead of @icp-sdk/core/*. Meanwhile the latest @icp-sdk version in this PR no longer makes the @dfinity/* imports available.

We can probably also update didc assuming that this would generate @icp-sdk imports now, but I wanted to avoid going there inside this PR for now.

…e support those in Uint8Array already.

sea-snake · 2026-03-12T16:23:33Z

Superseded by #3666

sea-snake added 15 commits March 10, 2026 15:07

Remove dfinity utils

871a6ee

Copy over json replacer and reviver implementation from dfinity/utils.

5e1f1aa

Cleanup

d85b481

Remove from deps

d36cd8e

Update npm deps and node version

ed5c2e3

Merge branch 'sea-snake/remove-dfinity-utils' into sea-snake/update-n…

a4c6d1b

…pm-deps

Merge branch 'main' into sea-snake/update-npm-deps

94aae68

Fix eslint with svelte

5a1e766

Fix typing

93da06c

Fix svelte lint errors

8831349

Fix lint errors

1a8c1ab

Update vite node polyfills

abea907

Fix formatting

9d4ff89

Fix vite deps

f57b4ce

Remove old override

1d09e9f

sea-snake requested review from aterga and Copilot March 10, 2026 17:51

Copilot started reviewing on behalf of sea-snake March 10, 2026 17:51 View session

Fix sig-verifier-js wasm import

74a7183

Copilot AI reviewed Mar 10, 2026

View reviewed changes

src/frontend/src/lib/flows/authFlow.svelte.ts Show resolved Hide resolved

src/frontend/src/lib/utils/utils.ts Outdated Show resolved Hide resolved

src/frontend/src/lib/utils/webAuthnIdentity.ts Show resolved Hide resolved

sea-snake added 3 commits March 10, 2026 19:00

Fix wasm in sig-verifier-js

3d3e340

Feedback

e60e4f7

Fix vite forward plugin

13ea5d8

sea-snake requested a review from Copilot March 10, 2026 18:35

Copilot started reviewing on behalf of sea-snake March 10, 2026 18:36 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

aterga reviewed Mar 10, 2026

View reviewed changes

sea-snake added 3 commits March 10, 2026 20:52

Update node-version

ae9f3c9

Remove unnecessary global Buffer in base64/hex utils since latest nod…

d29b23a

…e support those in Uint8Array already.

Remove aria-hidden e2e hacks since those are no longer necessary.

61afa6f

sea-snake added 6 commits March 11, 2026 10:25

Fix edit dialog state

7a611ed

Fix authorization channel, revert state change

d44d3e6

Fix actor calls in CI

edcab2c

Maybe

c1ee102

Output playwright process to console

2705e3c

Fix errors

46ddda0

sea-snake closed this Mar 12, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Update npm deps and node version#3664

chore: Update npm deps and node version#3664
sea-snake wants to merge 28 commits intomainfrom
sea-snake/update-npm-deps

sea-snake commented Mar 10, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aterga Mar 10, 2026

Uh oh!

sea-snake Mar 10, 2026

Uh oh!

sea-snake commented Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

sea-snake commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Tests

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aterga Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

sea-snake Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

sea-snake commented Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sea-snake commented Mar 10, 2026 •

edited

Loading