Conversation
sea-snake
changed the title
sea-snake
requested review from
aterga and
Copilot
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Urdu localization and improves RTL support across the new-styling frontend, while also extending the translation update script to use GitHub Models and run translations in parallel.
Changes:
- Added
urlocale (including a fullur.pocatalog) and enabled it in the locale configuration. - Updated multiple UI components to behave correctly in RTL (logical spacing, icon flipping, forcing LTR for identity/phrase content where appropriate).
- Reworked
scripts/update-translationsto call GitHub Models API, send partial catalogs, and translate multiple locales in parallel.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/frontend/src/routes/(new-styling)/manage/(authenticated)/+layout.svelte | Adjusts logo/header layout for RTL-safe alignment and forces LTR where needed. |
| src/frontend/src/routes/(new-styling)/manage/(authenticated)/(access-and-recovery)/access/components/PasskeyItem.svelte | Uses logical margin (ms-auto) for RTL friendliness. |
| src/frontend/src/routes/(new-styling)/manage/(authenticated)/(access-and-recovery)/access/components/OpenIdItem.svelte | Uses logical margin (ms-auto) for RTL friendliness. |
| src/frontend/src/routes/(new-styling)/+page.svelte | Forces LTR for the brand header group on landing page. |
| src/frontend/src/routes/(new-styling)/(channel)/authorize/+layout.svelte | Uses logical padding/margins (pe-*, -me-*) for RTL support. |
| src/frontend/src/lib/locales/ur.po | Adds Urdu translations catalog. |
| src/frontend/src/lib/locales/id.po | Fills previously missing Indonesian translations. |
| src/frontend/src/lib/locales/es.po | Fills previously missing Spanish translations. |
| src/frontend/src/lib/locales/de.po | Fills previously missing German translations. |
| src/frontend/src/lib/constants/locale.constants.ts | Adds ur, enables it, and introduces getLocaleDirection. |
| src/frontend/src/lib/components/wizards/createRecoveryPhrase/views/Write.svelte | Forces LTR rendering for recovery phrase word grid. |
| src/frontend/src/lib/components/wizards/createRecoveryPhrase/views/VerifySelecting.svelte | Forces LTR rendering for phrase verification selection grid. |
| src/frontend/src/lib/components/views/RecoveryPhraseInput.svelte | Forces LTR direction for recovery phrase input grid. |
| src/frontend/src/lib/components/ui/Tooltip.svelte | Adjusts inline alignment behavior under RTL. |
| src/frontend/src/lib/components/ui/Toggle.svelte | Adds RTL-specific knob translation behavior. |
| src/frontend/src/lib/components/ui/Popover.svelte | Adjusts inline alignment behavior under RTL. |
| src/frontend/src/lib/components/ui/IdentitySwitcher.svelte | Uses logical positioning and flips arrow icon in RTL. |
| src/frontend/src/lib/components/layout/Header.svelte | Forces LTR direction for the brand link group. |
| src/frontend/src/hooks.client.ts | Sets <html lang> and <html dir> based on current locale. |
| scripts/update-translations | Switches to GitHub Models API, adds retries/backoff, and parallel translation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
aterga
approved these changes
Mar 11, 2026
sea-snake
deleted the
sea-snake/add-urdu-language-fix-rtl-and-update-existing-languages
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Urdu language, fix RTL and update existing languages
Changes
Tests
All existing tests should pass as-is.