fix(frontend): Allow new QR code library in the CSP#12167
Merged
AntonioVentilii merged 1 commit intomainfrom Mar 25, 2026
Merged
fix(frontend): Allow new QR code library in the CSP#12167AntonioVentilii merged 1 commit intomainfrom
AntonioVentilii merged 1 commit intomainfrom
Conversation
DenysKarmazynDFINITY
approved these changes
Mar 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the frontend build configuration and CSP to support the new WASM-based QR scanning stack (barcode-detector) introduced for the QrCodeReader component.
Changes:
- Switches Vite “lazy” chunking from
html5-qrcodetobarcode-detector. - Updates
QrCodeScannerto handle a newnnsQRCodeErrorevent fromQrCodeReader. - Relaxes CSP
script-srcto includewasm-unsafe-evalto allow WebAssembly compilation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
vite.config.ts |
Updates Rollup manual chunking to treat barcode-detector as a lazily-loaded dependency. |
src/frontend/src/lib/components/qr/QrCodeScanner.svelte |
Adds handling for QR reader error events during scanning. |
scripts/build.csp.mjs |
Adjusts CSP script-src to permit WASM compilation required by the new scanner library. |
Comments suppressed due to low confidence (1)
vite.config.ts:37
barcode-detectorpulls inzxing-wasm(via dependency), but onlybarcode-detectorwas added to thelazychunk allowlist. With the currentmanualChunkslogic,zxing-wasmmodules will likely land in thevendorchunk and be downloaded eagerly, which defeats the purpose of lazy-loading the QR scanning stack. Consider addingzxing-wasm(and any other large transitive deps used exclusively for scanning) to thelazylist so they remain in the lazy chunk.
const lazy = ['@dfinity/nns', '@dfinity/nns-proto', 'barcode-detector', 'qr-creator'];
if (
['@sveltejs', 'svelte', '@dfinity/gix-components', ...lazy].find((lib) =>
folder.includes(lib)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
To use the new library from
QrCodeReadercomponent (PR #12162) we need to allow it in the CSP.