Skip to content

feat: First draft of flexible http outcalls#5890

Draft
oggy-dfin wants to merge 28 commits intomasterfrom
oggy/flexible-http-outcalls
Draft

feat: First draft of flexible http outcalls#5890
oggy-dfin wants to merge 28 commits intomasterfrom
oggy/flexible-http-outcalls

Conversation

@oggy-dfin
Copy link
Contributor

@oggy-dfin oggy-dfin commented Jun 27, 2025

Thank you for your contribution to the IC Developer Portal. This repo contains the content for https://internetcomputer.org and the ICP Developer Documentation, https://internetcomputer.org/docs/.

If you are submitting a pull request for adding or changing content on the ICP Developer Documentation, please make sure that your contribution meets the following requirements:

@github-actions github-actions bot added the interface-spec Changes to the IC Interface Specification label Jun 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2025

🤖 Here's your preview: https://hada6-4yaaa-aaaam-abaha-cai.icp0.io

@oggy-dfin oggy-dfin force-pushed the oggy/flexible-http-outcalls branch from 748a6ef to b40ad06 Compare September 22, 2025 12:13
@oggy-dfin oggy-dfin force-pushed the oggy/flexible-http-outcalls branch from e14bba0 to 14a0954 Compare November 12, 2025 15:04
@oggy-dfin oggy-dfin changed the title First draft of flexible http outcalls feat: First draft of flexible http outcalls Nov 12, 2025
oggy-dfin and others added 3 commits November 21, 2025 14:59
Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>
Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>
Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>
@mihailjianu1 mihailjianu1 marked this pull request as ready for review January 28, 2026 09:50
@mihailjianu1 mihailjianu1 requested review from a team as code owners January 28, 2026 09:50
Copy link
Contributor

@mraszyk mraszyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some more feedback.

The cost of a canister http outcall via [`http_request`](#ic-http_request). `request_size` is the sum of the byte lengths of the following components of an http request:
:::note

The `ic0.cost_http_request` System API call is DEPRECATED. Canister developers are advised to use the `ic0.cost_http_request_v2` call instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should point out that they should also use the new pricing version in that case (otherwise their calls might not work, right?).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already mention on line 3040 that pricing_version = 1 is deprecated. Are you saying we should also mention it here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong preference. If you think the current formulation is sufficient, then I'm also perfectly fine.

@mihailjianu1 mihailjianu1 marked this pull request as draft January 29, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

interface-spec Changes to the IC Interface Specification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants