feat: First draft of flexible http outcalls#5890
Draft
Conversation
Contributor
|
🤖 Here's your preview: https://hada6-4yaaa-aaaam-abaha-cai.icp0.io |
oggy-dfin
commented
Jun 27, 2025
748a6ef to
b40ad06
Compare
Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>
mraszyk
reviewed
Oct 13, 2025
THLO
reviewed
Oct 29, 2025
e14bba0 to
14a0954
Compare
oggy-dfin
commented
Nov 19, 2025
mraszyk
reviewed
Nov 21, 2025
mraszyk
reviewed
Nov 21, 2025
mraszyk
reviewed
Nov 21, 2025
mraszyk
reviewed
Nov 21, 2025
mraszyk
reviewed
Nov 21, 2025
mraszyk
reviewed
Nov 21, 2025
mraszyk
reviewed
Nov 21, 2025
Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>
Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>
Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>
Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>
fspreiss
reviewed
Jan 26, 2026
mraszyk
reviewed
Jan 28, 2026
Contributor
mraszyk
left a comment
There was a problem hiding this comment.
Left some more feedback.
mraszyk
reviewed
Jan 28, 2026
mraszyk
reviewed
Jan 28, 2026
mraszyk
reviewed
Jan 29, 2026
mraszyk
reviewed
Jan 29, 2026
mraszyk
reviewed
Jan 29, 2026
| The cost of a canister http outcall via [`http_request`](#ic-http_request). `request_size` is the sum of the byte lengths of the following components of an http request: | ||
| :::note | ||
|
|
||
| The `ic0.cost_http_request` System API call is DEPRECATED. Canister developers are advised to use the `ic0.cost_http_request_v2` call instead. |
Contributor
There was a problem hiding this comment.
Maybe we should point out that they should also use the new pricing version in that case (otherwise their calls might not work, right?).
Contributor
There was a problem hiding this comment.
We already mention on line 3040 that pricing_version = 1 is deprecated. Are you saying we should also mention it here?
Contributor
There was a problem hiding this comment.
I don't have a strong preference. If you think the current formulation is sufficient, then I'm also perfectly fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the IC Developer Portal. This repo contains the content for https://internetcomputer.org and the ICP Developer Documentation, https://internetcomputer.org/docs/.
If you are submitting a pull request for adding or changing content on the ICP Developer Documentation, please make sure that your contribution meets the following requirements:
.mdxfile format to support the previous two components./sidebars.js, otherwise, it will not appear in theside navigation bar.
.github/CODEOWNERSfile iscontains any new directories or specific documents that you added that should be reviewed by a specific teamm.