Skip to content

fix: Do not set NODE_ENV #4008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Do not set NODE_ENV #4008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e5ef23
Do not set NODE_ENV
fxgst Nov 20, 2024
7ebe365
Merge branch 'master' into elias/node-env
fxgst Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

# UNRELEASED

### chore: `dfx deploy --ic` does not set `NODE_ENV` to `production` anymore

### feat: error when using insecure identity on mainnet

This used to be a warning. A hard error can abort the command so that no insecure state will be on the mainnet.
Expand All @@ -10,6 +12,7 @@ Users can surpress this error by setting `export DFX_WARNING=-mainnet_plaintext_

The warning won't display when executing commands like `dfx deploy --playground`.


# 0.24.3

### feat: Bitcoin support in PocketIC
Expand Down
5 changes: 0 additions & 5 deletions src/dfx/src/lib/builders/assets.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ use anyhow::{anyhow, Context};
use candid::Principal as CanisterId;
use console::style;
use dfx_core::config::cache::Cache;
use dfx_core::config::model::network_descriptor::NetworkDescriptor;
use fn_error_context::context;
use slog::{o, Logger};
use std::fs;
Expand Down Expand Up @@ -214,10 +213,6 @@ fn build_frontend(
cmd.arg("--workspace").arg(workspace);
}

if NetworkDescriptor::is_ic(network_name, &vec![]) {
cmd.env("NODE_ENV", "production");
}

for (var, value) in vars {
cmd.env(var.as_ref(), value);
}
Expand Down
Loading