feat: migrate @dfinity/* to @icp-sdk/core and icp-cli (#378)#381
Merged
andreacerulli merged 3 commits intomainfrom Apr 22, 2026
Merged
feat: migrate @dfinity/* to @icp-sdk/core and icp-cli (#378)#381andreacerulli merged 3 commits intomainfrom
andreacerulli merged 3 commits intomainfrom
Conversation
Migrate the frontend library and backend infrastructure from deprecated
@dfinity/* packages and dfx to @icp-sdk/core and icp-cli.
Frontend library (frontend/ic_vetkeys):
- Replace @dfinity/{agent,principal,candid,identity} with @icp-sdk/core
- Regenerate declarations with @icp-sdk/bindgen@0.3.0
- Replace createActor wrappers with direct Actor.createActor calls
- Update test host ports and add canister ID null guards
- Reformat tsconfig, vite.config, eslint config
Backend infrastructure:
- Replace dfx.json with icp.yaml for all backend canisters
- Update Makefiles for icp-cli compatible builds
- Update test key from dfx_test_key to test_key_1
- Update CI workflows for icp-cli
CI:
- Update frontend.yml and backend-motoko.yml for icp-cli
- Update provision scripts
- Add .icp to .gitignore
marc0olo
approved these changes
Apr 22, 2026
Member
marc0olo
left a comment
marc0olo
left a comment
There was a problem hiding this comment.
LGTM from my side. I compared this against my earlier PR #365 (which I had fully tested locally), and the changes to all overlapping files are identical except for two intentional differences:
.github/workflows/backend-motoko.yml: #381 adds asetup-node@v4step for both Linux and Darwin jobs, which #365 was missing — this is a good addition..gitignore: #365 also addedfrontend/ic_vetkeys/.test*.env, but that entry turns out to be unnecessary (no such files are generated), so omitting it here is fine.
Approving. ✅
randombit
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the frontend library and backend infrastructure from deprecated @dfinity/* packages and dfx to @icp-sdk/core and icp-cli.
Frontend library (frontend/ic_vetkeys):
Backend infrastructure:
CI: