Pass vendor files as helpers to node-jasmine.#72
Open
bryanbraun wants to merge 1 commit intodflynn15:masterfrom
Open
Pass vendor files as helpers to node-jasmine.#72bryanbraun wants to merge 1 commit intodflynn15:masterfrom
bryanbraun wants to merge 1 commit intodflynn15:masterfrom
Conversation
For details on helpers, see: http://jasmine.github.io/2.4/node.html#section-12 See also, about jasmine.loadConfig: http://jasmine.github.io/2.4/node.html#section-Load_configuration_from_a_file_or_from_an_object.
Owner
|
This allows the change to work for Unit tests running against Jasmine's CLI, however the same scenario could exist for Integration tests run through Phantom as well. Would you mind adding the following:
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We came across an issue where we needed to pass vendor files in above specfiles for node-jasmine. This change allows the option to be passed through.
For details on helpers, see:
http://jasmine.github.io/2.4/node.html#section-12
See also, about jasmine.loadConfig:
http://jasmine.github.io/2.4/node.html#section-Load_configuration_from_a_file_or_from_an_object.