Correct AttributeError from Conditional Statements (k1._has_jitter)#143
Open
exowanderer wants to merge 2 commits intodfm:masterfrom
Open
Correct AttributeError from Conditional Statements (k1._has_jitter)#143exowanderer wants to merge 2 commits intodfm:masterfrom
exowanderer wants to merge 2 commits intodfm:masterfrom
Conversation
[terms.py: Line 221] raises an AttributeError for kernels lacking the `_has_jitter` flag attribute. Not all kernels include the flag attribute `_has_jitter`; and therefore, when multiplying 2 kernels that do not include the `_has_jitter` flag, the original version of this condition `if k1._has_jitter or k2._has_jitter` raises an AttributeError: "`k1` does not have the attribute `_has_jitter`" (paraphrased). By checking if the kernel `k1` or `k2` has the attribute `_has_jitter` at all, before checking if it will return True/False mitigates this AttributeError.
Owner
|
I know it's been forever, but ..... Which terms wouldn't have that attribute? It's implemented as part of the base class: https://github.com/dfm/celerite/blob/main/celerite/terms.py#L35 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[terms.py: Line 221] raises an AttributeError for kernels lacking the
_has_jitterflag attribute.Not all kernels include the flag attribute
_has_jitter; and therefore, when multiplying 2 kernels that do not include the_has_jitterflag, the original version of this conditionif k1._has_jitter or k2._has_jitterraises an AttributeError: "k1does not have the attribute_has_jitter" (paraphrased).By checking if the kernel
k1ork2has the attribute_has_jitterat all, before checking if it will return True/False mitigates this AttributeError.