Add seed argument to EnsembleSampler #376
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove rand -> random, randn -> standard_normal and try except with randint/integers
Owner
Author
|
The tests are failing because we need to change import packagingto import packaging.version |
Owner
Author
|
@OriolAbril: If you check the "allow edits from maintainers" checkbox, then I can take over from here. |
Contributor
|
I don't have the option to either, probably because I did not open the PR, but I can give both you and @carlosgmartin access to my fork. |
|
What is the status of this PR? Any change it can go in a new release? |
Contributor
|
I should point out SPEC-007, which is trying to normalise how random numbers are using within the scientific ecosystem. The main items are converging on the use of an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously opened as #332, but because of branch renaming issues we had to reopen it. This is @OriolAbril's work, but @carlosgmartin might also be interested. I'll try to summarize where we stand from the previous thread shortly, but I think we were just about there. Anything in particular that was missing?