Skip to content

Review database #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dartm05 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Review database #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions db/MongoUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ const MongoClient = require("mongodb").MongoClient;
function MongoUtils() {
const mu = {};

//No es recomendable mostrar ninguna credencial al repositorio. Tengo entendido que el uso de dotenv es preferiblemente para uso de desarrollo.
//En el caso de Heroku todas estas variables se pueden agregar al ambiente del servidor (en el app.json)
let hostname = "localhost",
port = 27017,
dbName = "heroku_3lrh51h6",
Expand All @@ -19,6 +21,7 @@ function MongoUtils() {
_hostName !== undefined ? ((hostname = _hostName), mu) : hostname;
mu.port = _port => (_port !== undefined ? ((port = _port), mu) : port);

//Acá dejaron imprimiendo en consola las credenciales.
mu.connect = () => {
console.log("Trying to connect");
let url;
Expand Down Expand Up @@ -60,6 +63,7 @@ function MongoUtils() {
return usersC.insertOne(user).finally(() => client.close());
});

//En este método se les olvidó cerrar el cliente. Esto puede crear mal uso de los recursos.
mu.users.find = client => {
const usersC = client.db(dbName).collection(colName);
return usersC
Expand Down