Skip to content

Recomendaciones que pueden ser útiles index.js #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dartm05 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Recomendaciones que pueden ser útiles index.js #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions routes/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ router.get("/getTest", function(req, res) {
.then(mu.getTest)
.then(res.json);
});

//Hubiese sido bueno, pero trabajoso que utilizaran algun sistema de autenticación para que un mismo usuario no ponga su score mil veces, sino que se reemplace el mejor del usuario.
//aunque es interesante que antes se usaban así en las consolas de salas de juego. Chevere.
router.post("/signUp", (req, res) => {
const user = {
userName: req.body.nameValue,
Expand All @@ -25,7 +26,8 @@ router.post("/signUp", (req, res) => {
.then(res.redirect("/getUsers"))
.catch(err => console.log(err));
});

//En cuanto a los métodos, hubiese sido util que el connect fuese manejado desde el archivo de la base de datos.
// es mucho mejor para no tener código repetido y mejorar el mantenimiento del código.
router.get("/getUsers", function(req, res) {
mu.connect()
.then(mu.users.find)
Expand Down