agilent: Implement new uncertainty and other fixes#244
Merged
PeterKraus merged 4 commits intomainfrom Aug 26, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yadg-7.0#240 foragilent.csv,agilent.ch,agilent.dxparsers:agilent.chandagilent.dxthis is trivial, as a scaling factor has been used previously.agilent.csv, we now pick the maximum value from thestr -> floatconversion for each trace; the test file that is available shows that the number of decimal places is constant in the whole file and scientific notation is not used, i.e. the uncertainty is absolute.agilent.csv, we now assignelution_timeas a proper coordinate ofsignal. We also remove any manual padding. Theelution_timeis now expanded as necessary on concatenation (usingxr.concat), andnp.nans are inserted intosignalat the necessary positions automatically.