Merged
Conversation
dgonzalez
requested changes
Mar 20, 2017
Owner
dgonzalez
left a comment
dgonzalez
left a comment
There was a problem hiding this comment.
Looks good. Just change the license and I will merge it. This is the correct repo.
examples/econ-refused/package.json
Outdated
| "private": true, | ||
| "main": "econ-refused.js", | ||
| "author": "", | ||
| "license": "ISC", |
Owner
There was a problem hiding this comment.
License should be MIT (as per base repo)
Owner
There was a problem hiding this comment.
Applies for all the other examples.
Author
There was a problem hiding this comment.
Sure will Update this just quickly Cherry picked the old One
wzrdtales
force-pushed
the
minorFixesNew
branch
from
be65519 to
794c49d
Compare
wzrdtales
force-pushed
the
minorFixesNew
branch
from
794c49d to
1e0a6cb
Compare
Author
|
@dgonzalez Pushed the requested changes out. About the repo constellation. It is quite a struggle to open a PR in this constellation as you always end up by default in rjdoger ones. Is there a special reason for this structure? |
Owner
|
No, repo will be transferred to my account. This is the right one. Thanks for your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As talked the transfer from dgonzalez/visigoth-old#2
not sure where it should be opened up on, its there in both places now:
rjrodger#3