Remove grpc dependency
#233
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
grpcdependency is causing the issue shown in issue #231 due to an incompatibility with the most recent version ofgrpcand any platform other than Linux based on our testing. We've also shown reports that the prebuilt binaries downloaded bygprcare causing massive bloat (nearly a 5x increase in size) to our bundles that are generated with the dependency included.Upon investigation, we noticed that
grpcisn't actually used by anything in the library anymore, and was seemingly added back by mistake during the most recent release, as@grpc/grpc-jsis used in place of it.Sources:
Original PR to remove
grpcPR I made last year, where
grpcwas not in the list of dependencies at the time, reinforcing the fact that it was added back by mistakeThe README of this very repo, which has instructions to install
@grpc/grpc-jsand notgrpc, and here is the PR where that change was madeThis PR is to remove the
grpcdependency from the package to accomplish the following: