Skip to content

Remove runtime log #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2025
Merged

Remove runtime log #268

merged 1 commit into from
Jun 3, 2025

Conversation

@danstarns
Copy link
Contributor

@danstarns danstarns commented Jun 3, 2025

This small console.log was showing up when testing with the driver.

This PR switches it to use this.debug.

Screenshot 2025-06-03 at 19 22 36

Copilot AI review requested due to automatic review settings June 3, 2025 12:23
@danstarns danstarns requested a review from johnymontana as a code owner June 3, 2025 12:23
@danstarns danstarns requested a review from a team June 3, 2025 12:23
Copilot AI reviewed Jun 3, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces a runtime console.log call with the class’s debug method to avoid printing during normal operation.

  • Swapped console.log for this.debug on successful client stub closure.

@danstarns danstarns merged commit 125361c into main Jun 3, 2025
9 checks passed
@danstarns danstarns deleted the remove-log branch June 3, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@johnymontana johnymontana Awaiting requested review from johnymontana

+1 more reviewer

@ryanfoxtyler ryanfoxtyler ryanfoxtyler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danstarns @ryanfoxtyler