Skip to content

Fix HTTP/2 build error by implementing RoundTripper adapter #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgrr merged 1 commit into from
Jun 22, 2025
Merged

Fix HTTP/2 build error by implementing RoundTripper adapter #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 21 additions & 10 deletions configure.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,17 @@ import (
// ErrServerSupport indicates whether the server supports HTTP/2 or not.
var ErrServerSupport = errors.New("server doesn't support HTTP/2")

// clientAdapter adapts a Client.Do method to implement fasthttp.RoundTripper
type clientAdapter struct {
client *Client
}

// RoundTrip implements fasthttp.RoundTripper by calling the wrapped client's Do method
func (ca *clientAdapter) RoundTrip(hc *fasthttp.HostClient, req *fasthttp.Request, resp *fasthttp.Response) (retry bool, err error) {
err = ca.client.Do(req, resp)
return false, err
}

func configureDialer(d *Dialer) {
if d.TLSConfig == nil {
d.TLSConfig = &tls.Config{
Expand Down Expand Up @@ -67,7 +78,7 @@ func ConfigureClient(c *fasthttp.HostClient, opts ClientOpts) error {
c.IsTLS = true
c.TLSConfig = d.TLSConfig

c.Transport = cl
c.Transport = &clientAdapter{client: cl}

return nil
}
Expand All @@ -79,14 +90,14 @@ func ConfigureClient(c *fasthttp.HostClient, opts ClientOpts) error {
// Future implementations may support HTTP/2 through plain TCP.
//
// This package currently supports the following fasthttp.Server settings:
// - Handler: Obviously, the handler is taken from the Server.
// - ReadTimeout: Will cancel a stream if the client takes more than ReadTimeout
// to send a request. This option NEVER closes the connection.
// - IdleTimeout: Will close the connection if the client doesn't send a request
// within the IdleTimeout. This option ignores any PING/PONG mechanism.
// To disable the option you can set it to zero. No value is taken by default,
// which means that by default ALL connections are open until either endpoint
// closes the connection.
// - Handler: Obviously, the handler is taken from the Server.
// - ReadTimeout: Will cancel a stream if the client takes more than ReadTimeout
// to send a request. This option NEVER closes the connection.
// - IdleTimeout: Will close the connection if the client doesn't send a request
// within the IdleTimeout. This option ignores any PING/PONG mechanism.
// To disable the option you can set it to zero. No value is taken by default,
// which means that by default ALL connections are open until either endpoint
// closes the connection.
func ConfigureServer(s *fasthttp.Server, cnf ServerConfig) *Server {
cnf.defaults()

Expand All @@ -113,4 +124,4 @@ func ConfigureServerAndConfig(s *fasthttp.Server, tlsConfig *tls.Config) *Server
return s2
}

var ErrNotAvailableStreams = errors.New("ran out of available streams")
var ErrNotAvailableStreams = errors.New("ran out of available streams")
Loading