fix: [#465] Avoid NPE with missing 'r' attribute#514
Merged
ochedru merged 3 commits intodhatim:masterfrom Apr 16, 2025
ursjoss:fix/465-handle-missing-r-attribute
Merged
fix: [#465] Avoid NPE with missing 'r' attribute#514ochedru merged 3 commits intodhatim:masterfrom ursjoss:fix/465-handle-missing-r-attribute
ochedru merged 3 commits intodhatim:masterfrom
ursjoss:fix/465-handle-missing-r-attribute
Conversation
Tracks both row and column indices to allow falling back to those to determine row and/or cell address for Excel files that do not provide the (optional) reference attribute 'r'. Inspired by the apache poi approach.
Contributor
Author
|
@ochedru Is there anything we can do to help getting this PR merged? We would of course also be interested in a new release of the library containing this fix. What could be a realistic window for that? |
Collaborator
|
Hi @ursjoss, thanks for contributing! Sorry for the delay, merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #465
For the case the (optional)
rattribute is not present, the code tracks the running line and column number, falling back to those if therattribute does not provide the proper addresses.Adds a test case (
issue514.xlsx), that fails being processed (with the reported NPE) and passes with the fix.Please note: The file that was provided by the ticket reporter @fabiospiga has different issues in addition to the reported NPE. The fix of this PR does help to not throw the reported NPE also for that file, but it does not address the other issues (I tried with a time-box but failed to get it fully processed). The PR let's us process the file that brought us to this ticket in the first place.
Inspired by the apache poi approach, see code here.
This PR is now complete IMHO and ready to be reviewed.