Add support for all columns in getCellMark#568
Merged
rzymek merged 1 commit intodhatim:masterfrom Dec 4, 2025
Merged
Conversation
|
We use it extensively and the PR was created to fix the issue we face very often. |
rzymek
reviewed
Dec 4, 2025
| char columnLetter = (char) ('A' + coll); | ||
| return String.valueOf(columnLetter) + String.valueOf(row+1); | ||
| static String getCellMark(int row, int coll) { | ||
| if (0 <= coll && coll <= 'Z' - 'A') { |
Collaborator
There was a problem hiding this comment.
Why not use colToString always here? Perhaps make colToString static, so there's no need for the REF_HELPER
Collaborator
There was a problem hiding this comment.
Also there's CellAdress.toString
Collaborator
|
Consolidated col-index-to-string logic in 25ecdff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #567
This change makes the getCellMark method return the correct column strings for two- and three-letter columns as well and adds a POI test case that fails with the previous implementation but succeeds with the proposed one.