fix(#472): escape special characters in format codes #582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dhatim#472 Format codes containing quotation marks (e.g., ISO 8601 date format yyyy-MM-dd"T"HH:mm:ss) were written unescaped to the formatCode XML attribute, producing invalid XML that caused Excel repair dialogs. Apply XmlEscapeHelper.escape() to format codes in StyleCache.write().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #472: Quotation marks in custom date/number formats (e.g.,
yyyy-MM-dd"T"HH:mm:ss) caused XML parsing errors and corrupted Excel files.Proposed Solution
Apply
XmlEscapeHelper.escape()to format codes before writing them to XML. This helper already exists in the codebase and handles all necessary XML escapes ("→",<→<, etc.).Changes
StyleCache.java:167e.getKey()withXmlEscapeHelper.escape()CorrectnessTest.javatestFormatCodeWithSpecialCharacters()Test plan
",<,>,&,'