Conversation
dhensby
left a comment
dhensby
left a comment
There was a problem hiding this comment.
Thanks for this. A couple of changes needed:
- Remove the change to the
.gitignore- if you have problems with your IDE's files being added to repos look into global gititnores - Please update the commit message to follow conventional commit standard - this is so the release bot can automatically publish this on merge. Please update the commit message so that we get a new major release:
feat!: SS6 support
BREAKING CHANGE: Update for use with SS6. SS6+ is not the minimum supported version.
BettinaMaria98
force-pushed
the
master
branch
from
b9644c8 to
01bacf0
Compare
|
The commits need squashing as the new commit does not meet the conventions |
BettinaMaria98
force-pushed
the
master
branch
2 times, most recently
from
1fe88c0 to
a913894
Compare
|
Thanks for your reply! I've made the changes — hopefully everything looks good now? |
|
sorry - last thing, can you rebase this against the current master as I've updated the CI to use PHP 8.3, which is needed for the tests to run/pass |
BettinaMaria98
force-pushed
the
master
branch
from
a913894 to
3b09c20
Compare
|
I've rebased against the current master — hopefully everything looks good now! Let me know if there's anything else that needs adjusting. |
|
Really sorry @BettinaMaria98 - the commit linting is a bit overly strict and I gave you a bad commit message. The commit message can't start with a capital letter 😠 could you change it to Then we really should be golden |
BREAKING CHANGE: Update for use with SS6. SS6+ is now the minimum supported version.
BettinaMaria98
force-pushed
the
master
branch
from
3b09c20 to
628862a
Compare
|
No worries! Fixed the commit message — should be good to go now 🤞 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2 participants
Update for Usage within CMS6