fix: add true no flag option [DHIS2-18263] #1448
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🚀 Deployed on https://pr-1448--dhis2-settings.netlify.app |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://dhis2.atlassian.net/browse/DHIS2-18263
This updates flag options in settings app to label dhis2 flag as
DHIS2and to add a new "No flag" option that has id ofnone. Note that whilenonedoes not exist as a hardcoded value on the backend, the backend will accept any string, and since there is no flag ofnone, we can use this as the null option.Existing implementations would see their "No flag" option become "DHIS2", which is more accurate. This will work in conjunction with the change in the login app dhis2/login-app#55