fix: allow user to input rgb values in color picker#1461
Open
fix: allow user to input rgb values in color picker#1461
Conversation
Contributor
|
🚀 Deployed on https://pr-1461.settings.netlify.dhis2.org |
- stop closing the picker on every rgb change event - rely on the backdrop click to close the picker after selecting/writing a color
d-rita
force-pushed
the
DHIS2-21011/fix-picker-rgb-input
branch
from
238280a to
2a2279f
Compare
|
KaiVandivier
approved these changes
Mar 9, 2026
Contributor
KaiVandivier
left a comment
KaiVandivier
left a comment
There was a problem hiding this comment.
Looks great! 🙌
Were you able to try out the "white box with a red line through it" design for the "No color selected" box?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of DHIS2-21011
Description
This PR allows users to edit the input fields for the hex codes as well as the RGB values without closing the color picker.
Screenshot
color-picker.mov